avoid executing embedded scripts multiple times. click to hide

1 files changed, 30 insertions, 28 deletions

diff --git a/frontend/app/views/tile/handles/tile.script.js b/frontend/app/views/tile/handles/tile.script.js
index 47d83a1..e844adf 100644
--- a/frontend/app/views/tile/handles/tile.script.js
+++ b/frontend/app/views/tile/handles/tile.script.js
@@ -1,34 +1,36 @@
-import React from 'react'
+import React, { Component } from 'react'
 import { generateTransform } from 'app/views/tile/tile.utils'
 
-export default function TileScript({ tile, box, bounds, videoBounds, viewing, onMouseDown, onDoubleClick }) {
-  // console.log(tile)
-  const style = {
-    transform: generateTransform(tile, box, bounds, videoBounds),
-    opacity: tile.settings.opacity,
-  }
-  // console.log(generateTransform(tile))
-  let content;
-  let className = ['tile', tile.type].join(' ')
-  if (tile.target_page_id || (viewing && tile.href)) {
-    className += ' ' + (tile.settings.cursor || 'hand_up')
+export default class TileScript extends Component {
+  componentDidMount(){
+    const { viewing, tile } = this.props
+    if (viewing) {
+      eval(tile.settings.content)
+    }
   }
+  render() {
+    if (viewing) {
+      return <div style={{ display: 'none' }} />
+    }
 
-  content = ""
-  if (viewing) {
-    eval(tile.settings.content)
-  } else {
-    content = "SCRIPT"
-  }
+    const { tile, box, bounds, videoBounds, viewing, onMouseDown, onDoubleClick } = this.props
+    // console.log(tile)
+    const style = {
+      transform: generateTransform(tile, box, bounds, videoBounds),
+      opacity: tile.settings.opacity,
+    }
+    // console.log(generateTransform(tile))
+    let className = ['tile', tile.type, 'hand_up'].join(' ')
 
-  return (
-    <div
-      className={className}
-      onMouseDown={onMouseDown}
-      onDoubleClick={onDoubleClick}
-      style={style}
-    >
-      {content}
-    </div>
-  )
+    return (
+      <div
+        className={className}
+        onMouseDown={onMouseDown}
+        onDoubleClick={onDoubleClick}
+        style={style}
+      >
+        {"SCRIPT"}
+      </div>
+    )
+  }
 }