types

2 files changed, 15 insertions, 9 deletions

diff --git a/scraper/client/paper/paper.citations.js b/scraper/client/paper/paper.citations.js
index 53923c6e..3df9ea0c 100644
--- a/scraper/client/paper/paper.citations.js
+++ b/scraper/client/paper/paper.citations.js
@@ -6,6 +6,7 @@ import { Link } from 'react-router-dom'
 import * as actions from '../actions'
 
 import { TableObject } from '../common'
+import { USES_DATASET } from '../types'
 
 class PaperCitations extends Component {
   componentDidMount() {
@@ -36,10 +37,11 @@ class PaperCitations extends Component {
           cite.s2 = {
             _raw: true,
             value: <a
-            href={'https://www.semanticscholar.org/paper/' + citation.id}
-            target="_blank"
-            className={'pdfLink'}
-          >{'[semantic scholar]'}</a>
+              href={'https://www.semanticscholar.org/paper/' + citation.id}
+              target="_blank"
+              rel="noopener noreferrer"
+              className={'pdfLink'}
+            >{'[semantic scholar]'}</a>
           }
           cite.addresses = {
             _raw: true,
@@ -47,11 +49,15 @@ class PaperCitations extends Component {
               <div key={j}>{address.name}{', '}<span className='type'>{address.type}</span></div>
             ))
           }
-          if (citation.id in verifications) {
+          if (citation.id in verifications && verifications[citation.id].dataset === dataset.key) {
             const verification = verifications[citation.id]
             cite.verified = {
               _raw: true,
-              value: verification['uses_dataset'] === 'TRUE' ? <span className='verified'>uses dataset</span> : <span className='unverified'>doesn't use dataset</span>
+              value: verification.uses_dataset === USES_DATASET.YES
+                ? <span className='verified'>uses dataset</span>
+                : verification.uses_dataset === USES_DATASET.NO
+                  ? <span className='unverified'>doesn\'t use dataset</span>
+                  : <span className='unknown'>not enough information</span>
             }
           }
           else {
diff --git a/scraper/client/types.js b/scraper/client/types.js
index 6d19984d..95b7a4e3 100644
--- a/scraper/client/types.js
+++ b/scraper/client/types.js
@@ -13,7 +13,7 @@ export const api = tagAsType('api', [
 export const init = '@@INIT'
 
 export const USES_DATASET = {
-  YES: 1,
-  NO: -1,
-  UNKNOWN: 0,
+  YES: "1",
+  NO: "-1",
+  UNKNOWN: "0",
 }