From bb3d8da23279dc2e4cf275b08b03148b3980fb01 Mon Sep 17 00:00:00 2001 From: Sean Fridman Date: Wed, 8 Apr 2015 18:28:26 -0400 Subject: Fix bug where views didn't resolve resource correctly --- app/index.js | 2 +- app/node_modules/okview/index.js | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'app') diff --git a/app/index.js b/app/index.js index 0e83363..792c10a 100644 --- a/app/index.js +++ b/app/index.js @@ -152,7 +152,7 @@ OKCMS.prototype._createQueries = function(queryConfig, resourceCache) { queryConfig = [queryConfig]; return queryConfig.map(function(config) { var type = config.type; - var resource = resourceCache.get(type); + var resource = resourceCache.get(type, config.query); if (!resource) throw new Error('Query configured with nonexistent resource'); // Default to "select all" query diff --git a/app/node_modules/okview/index.js b/app/node_modules/okview/index.js index e9c0bfe..c245b0c 100644 --- a/app/node_modules/okview/index.js +++ b/app/node_modules/okview/index.js @@ -51,8 +51,11 @@ function OKView(options) { this._fetchTemplateData = unbound ? fetchUnbound : fetchBound; function fetchUnbound(id) { - // TODO Janky - return fetchTemplateData(meta, [queries[0].get(id)]); + var resource = queries[0].resource; + return fetchTemplateData(meta, [OKQuery({ + resource: resource, + query: id + })]); } function fetchBound() { @@ -150,9 +153,10 @@ function fetchTemplateData(meta, queries) { .then(function(results) { var metadata = results.shift(); var normalized = results.reduce(function(cache, result, i) { - // Huh? Bail - if (!result) + // Could be just some rogue request + if (!result) { return cache; + } var resource = queries[i].resource; var type = queries[i].type; var manyResult = isarray(result); -- cgit v1.2.3-70-g09d2