From 2b2d6a5048dc75cd1d3f7ec6b8829862ea0129dd Mon Sep 17 00:00:00 2001 From: jules Date: Fri, 22 Aug 2014 17:20:44 -0400 Subject: fix cielab-to-xyz --- js/color.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'js/color.js') diff --git a/js/color.js b/js/color.js index ba60db7..ddabf1d 100644 --- a/js/color.js +++ b/js/color.js @@ -114,9 +114,9 @@ function cielab2xyz (lab){ if ( var_Z^3 > 0.008856 ) var_Z = Math.pow(var_Z, 3) else var_Z = ( var_Z - 16 / 116 ) / 7.787 - var X = REF_X * var_X //ref_X = 95.047 Observer= 2°, Illuminant= D65 - var Y = REF_Y * var_Y //ref_Y = 100.000 - var Z = REF_Z * var_Z //ref_Z = 108.883 + var x = REF_X * var_X //ref_X = 95.047 Observer= 2°, Illuminant= D65 + var y = REF_Y * var_Y //ref_Y = 100.000 + var z = REF_Z * var_Z //ref_Z = 108.883 return [x,y,z] } -- cgit v1.2.3-70-g09d2 From d4460f375dd7cf29faf0f53947b3fb5e405a0e25 Mon Sep 17 00:00:00 2001 From: jules Date: Tue, 26 Aug 2014 19:06:03 -0400 Subject: handle divide-by-zero error on xyz2hunterlab --- js/color.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/color.js') diff --git a/js/color.js b/js/color.js index ddabf1d..879a78b 100644 --- a/js/color.js +++ b/js/color.js @@ -57,7 +57,7 @@ function xyz2rgb(xyz){ function xyz2hunterlab (XYZ) { var X = XYZ[0] - var Y = XYZ[1] + var Y = XYZ[1] || 1e-6 // otherwise divide-by-zero error when converting rgb(0,0,0) var Z = XYZ[2] var L = 10 * sqrt( Y ) var a = 17.5 * ( ( ( 1.02 * X ) - Y ) / sqrt( Y ) ) -- cgit v1.2.3-70-g09d2 From 984f2c492c8ffd6bf6b4717557ccf835f240a592 Mon Sep 17 00:00:00 2001 From: jules Date: Mon, 29 Sep 2014 16:24:38 -0400 Subject: found some carats that should be Math.pow --- js/color.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'js/color.js') diff --git a/js/color.js b/js/color.js index 879a78b..5073e7f 100644 --- a/js/color.js +++ b/js/color.js @@ -16,11 +16,11 @@ function rgb2xyz(rgb){ var var_G = ( rgb[1] / 255 ) //G from 0 to 255 var var_B = ( rgb[2] / 255 ) //B from 0 to 255 - if ( var_R > 0.04045 ) var_R = ( ( var_R + 0.055 ) / 1.055 ) ^ 2.4 + if ( var_R > 0.04045 ) var_R = Math.pow(( ( var_R + 0.055 ) / 1.055, 2.4) else var_R = var_R / 12.92 - if ( var_G > 0.04045 ) var_G = ( ( var_G + 0.055 ) / 1.055 ) ^ 2.4 + if ( var_G > 0.04045 ) var_G = Math.pow(( ( var_G + 0.055 ) / 1.055, 2.4) else var_G = var_G / 12.92 - if ( var_B > 0.04045 ) var_B = ( ( var_B + 0.055 ) / 1.055 ) ^ 2.4 + if ( var_B > 0.04045 ) var_B = Math.pow(( ( var_B + 0.055 ) / 1.055, 2.4) else var_B = var_B / 12.92 var_R = var_R * 100 @@ -107,11 +107,11 @@ function cielab2xyz (lab){ var var_X = lab[1] / 500 + var_Y var var_Z = var_Y - lab[2] / 200 - if ( var_Y^3 > 0.008856 ) var_Y = Math.pow(var_Y, 3) + if ( Math.pow(var_Y, 3) > 0.008856 ) var_Y = Math.pow(var_Y, 3) else var_Y = ( var_Y - 16 / 116 ) / 7.787 - if ( var_X^3 > 0.008856 ) var_X = Math.pow(var_X, 3) + if ( Math.pow(var_X, 3) > 0.008856 ) var_X = Math.pow(var_X, 3) else var_X = ( var_X - 16 / 116 ) / 7.787 - if ( var_Z^3 > 0.008856 ) var_Z = Math.pow(var_Z, 3) + if ( Math.pow(var_Z, 3) > 0.008856 ) var_Z = Math.pow(var_Z, 3) else var_Z = ( var_Z - 16 / 116 ) / 7.787 var x = REF_X * var_X //ref_X = 95.047 Observer= 2°, Illuminant= D65 -- cgit v1.2.3-70-g09d2 From 1631cdf643283fc71bc9d70b5dcbce03ab9c2386 Mon Sep 17 00:00:00 2001 From: jules Date: Mon, 29 Sep 2014 16:25:22 -0400 Subject: sp --- js/color.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'js/color.js') diff --git a/js/color.js b/js/color.js index 5073e7f..215c3e6 100644 --- a/js/color.js +++ b/js/color.js @@ -16,11 +16,11 @@ function rgb2xyz(rgb){ var var_G = ( rgb[1] / 255 ) //G from 0 to 255 var var_B = ( rgb[2] / 255 ) //B from 0 to 255 - if ( var_R > 0.04045 ) var_R = Math.pow(( ( var_R + 0.055 ) / 1.055, 2.4) + if ( var_R > 0.04045 ) var_R = Math.pow( ( var_R + 0.055 ) / 1.055, 2.4) else var_R = var_R / 12.92 - if ( var_G > 0.04045 ) var_G = Math.pow(( ( var_G + 0.055 ) / 1.055, 2.4) + if ( var_G > 0.04045 ) var_G = Math.pow( ( var_G + 0.055 ) / 1.055, 2.4) else var_G = var_G / 12.92 - if ( var_B > 0.04045 ) var_B = Math.pow(( ( var_B + 0.055 ) / 1.055, 2.4) + if ( var_B > 0.04045 ) var_B = Math.pow( ( var_B + 0.055 ) / 1.055, 2.4) else var_B = var_B / 12.92 var_R = var_R * 100 -- cgit v1.2.3-70-g09d2