From d4ece4ab1f461653c53bb56f23406c553ea78dd3 Mon Sep 17 00:00:00 2001 From: Jules Laplace Date: Tue, 12 Dec 2017 03:52:14 +0100 Subject: deleting threads with comments and files and s3 files --- bucky/app/bucky.js | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) (limited to 'bucky/app/bucky.js') diff --git a/bucky/app/bucky.js b/bucky/app/bucky.js index 15487e2..6ec76a0 100644 --- a/bucky/app/bucky.js +++ b/bucky/app/bucky.js @@ -161,13 +161,13 @@ var bucky = module.exports = { ensureCommentsForThread: function (req, res, next){ db.getCommentsForThread(res.thread.get('id')).then(function(comments){ - res.comments = comments + res.comments = comments || [] next() }) }, ensureFilesForThread: function (req, res, next){ db.getFilesForThread(res.thread.get('id')).then(function(files){ - res.files = files + res.files = files || [] next() }) }, @@ -185,24 +185,7 @@ var bucky = module.exports = { var commentPromises = res.comments.map((comment) => { return comment.destroy() }) - var s3client = upload.client() - var rmPromises = res.files.map((file) => { - return new Promise ((resolve, reject) => { - var thread_id = file.get('thread') - if (! thread_id || ! file.filename) { - console.log("weird malformed file?", file) - return resolve() - } - var filePath = '/bucky/' + thread_id + '/' + file.get('filename') - s3client.deleteFile(filePath, function(err, res){ - // check `err`, then do `res.pipe(..)` or `res.resume()` or whatever. - resolve() - }) - }) - }) - var filePromises = res.files.map((file) => { - return file.destroy() - }) + var filePromises = db.destroyFiles(res.files) var threadPromise = res.thread.destroy() var promises = [ threadPromise ].concat(commentPromises).concat(filePromises) Promise.all(promises).then( () => { -- cgit v1.2.3-70-g09d2