From 8baecd2240134937840d970a5f9e6462b3edf566 Mon Sep 17 00:00:00 2001 From: Jules Laplace Date: Thu, 23 Jul 2020 22:28:41 +0200 Subject: fix bug where annotations wouldnt update if start_ts == 0 --- animism-align/cli/app/controllers/annotation_controller.py | 4 ++++ animism-align/cli/app/sql/models/annotation.py | 2 +- .../app/views/align/components/annotations/annotation.form.js | 5 +++-- .../frontend/app/views/align/containers/annotations.container.js | 3 ++- animism-align/frontend/app/views/site/site.actions.js | 3 +-- animism-align/frontend/app/views/viewer/nav/viewer.nav.js | 2 +- animism-align/frontend/app/views/viewer/nav/viewer.router.js | 4 ++-- animism-align/frontend/app/views/viewer/nav/viewer.sections.nav.js | 2 +- 8 files changed, 15 insertions(+), 10 deletions(-) diff --git a/animism-align/cli/app/controllers/annotation_controller.py b/animism-align/cli/app/controllers/annotation_controller.py index 962d8f5..cd70d80 100644 --- a/animism-align/cli/app/controllers/annotation_controller.py +++ b/animism-align/cli/app/controllers/annotation_controller.py @@ -14,11 +14,15 @@ class AnnotationView(CrudView): def on_create(self, session, form, item): if 'paragraph_id' in form: item.paragraph_id = form['paragraph_id'] + if 'start_ts' in form: + item.start_ts = form['start_ts'] if 'settings' in form: item.settings = form['settings'] def on_update(self, session, form, item): if 'paragraph_id' in form: item.paragraph_id = form['paragraph_id'] + if 'start_ts' in form: + item.start_ts = form['start_ts'] if 'settings' in form: item.settings = form['settings'] diff --git a/animism-align/cli/app/sql/models/annotation.py b/animism-align/cli/app/sql/models/annotation.py index cc53bd6..2b42eac 100644 --- a/animism-align/cli/app/sql/models/annotation.py +++ b/animism-align/cli/app/sql/models/annotation.py @@ -34,6 +34,6 @@ class Annotation(Base): class AnnotationForm(ModelForm): class Meta: model = Annotation - exclude = ['settings'] + exclude = ['start_ts', 'settings'] def get_session(): return Session() diff --git a/animism-align/frontend/app/views/align/components/annotations/annotation.form.js b/animism-align/frontend/app/views/align/components/annotations/annotation.form.js index 7d66272..f4620bc 100644 --- a/animism-align/frontend/app/views/align/components/annotations/annotation.form.js +++ b/animism-align/frontend/app/views/align/components/annotations/annotation.form.js @@ -16,7 +16,9 @@ import { } from './annotationForms' const ANNOTATION_TYPES = [ - 'sentence', 'header', 'paragraph_end', 'video', 'image', 'image_carousel', + 'sentence', 'header', 'paragraph_end', + 'video', + 'image', 'image_carousel', ].map(name => ({ name, label: capitalize(name.replace('_', ' ')) })) class AnnotationForm extends Component { @@ -110,7 +112,6 @@ class AnnotationForm extends Component { } render() { const { timeline, annotation, media } = this.props - if (!annotation.start_ts) return
return (
- {this.props.annotation.start_ts && + {this.props.annotation.id && }
diff --git a/animism-align/frontend/app/views/site/site.actions.js b/animism-align/frontend/app/views/site/site.actions.js index 90e7249..b200f32 100644 --- a/animism-align/frontend/app/views/site/site.actions.js +++ b/animism-align/frontend/app/views/site/site.actions.js @@ -10,10 +10,9 @@ export const loadProject = () => dispatch => { actions.paragraph.index(), actions.media.index(), ]).then(() => { - console.log(arguments) actions.viewer.loadSections() }).catch(err => { - console.error(err) + // console.error(err) }) } diff --git a/animism-align/frontend/app/views/viewer/nav/viewer.nav.js b/animism-align/frontend/app/views/viewer/nav/viewer.nav.js index a0a9a1a..ab268a4 100644 --- a/animism-align/frontend/app/views/viewer/nav/viewer.nav.js +++ b/animism-align/frontend/app/views/viewer/nav/viewer.nav.js @@ -16,7 +16,7 @@ class ViewerNav extends Component {
- + actions.viewer.showSection('sections')}> {ROMAN_NUMERALS[0]} {'. '} diff --git a/animism-align/frontend/app/views/viewer/nav/viewer.router.js b/animism-align/frontend/app/views/viewer/nav/viewer.router.js index e352af5..93305cc 100644 --- a/animism-align/frontend/app/views/viewer/nav/viewer.router.js +++ b/animism-align/frontend/app/views/viewer/nav/viewer.router.js @@ -14,8 +14,8 @@ class ViewerRouter extends Component { case 'transcript': actions.viewer.showSection('transcript') break - case 'nav': - actions.viewer.showSection('nav') + case 'sections': + actions.viewer.showSection('sections') break case 'checklist': actions.viewer.showSection('checklist') diff --git a/animism-align/frontend/app/views/viewer/nav/viewer.sections.nav.js b/animism-align/frontend/app/views/viewer/nav/viewer.sections.nav.js index dcccfd5..f4ab93a 100644 --- a/animism-align/frontend/app/views/viewer/nav/viewer.sections.nav.js +++ b/animism-align/frontend/app/views/viewer/nav/viewer.sections.nav.js @@ -27,7 +27,7 @@ class ViewerSectionsNav extends Component {
- + actions.viewer.showSection('transcript')}> {'Transcript'}
-- cgit v1.2.3-70-g09d2